RFR [14] 8226303: Examine the HttpRequest.BodyPublishers for exception handling

[Chris Hegarty]

[ adding net-dev ]

Pavel,

> On 18 Jun 2019, at 14:22, Pavel Rappo <pavel.rappo at oracle.com> wrote:
> 
> Hello,
> 
> Please review the following change:
> 
> http://cr.openjdk.java.net/~prappo/8226303/webrev.00

This looks good. Just a few minor comments:

1) Please add the bug no. and a brief summary, to the test tags.

2) The creation and deletion of a file is necessary to exercise test
   scenario, but this could prove to be problematic, at least
   intermittently on Windows.

  64         Files.delete(file);
  65         if (Files.exists(file)) { // just an assumption of the test
  66             throw new RuntimeException("File hasn't been deleted");
  67         }

  Can I suggest that jdk.test.lib.util.FileUtils::deleteFileWithRetry be
  used instead of Files::delete, as it is less likely to fail.

-Chris.