RFR(XS): 8226286 Remove unused method java.lang.Integer::formatUnsignedInt

Brian Burkhalter brian.burkhalter at oracle.com
Tue Jun 18 15:49:30 UTC 2019


Hello,

> On Jun 17, 2019, at 9:55 PM, Tagir Valeev <amaembo at gmail.com> wrote:
> 
> Please review:
> https://bugs.openjdk.java.net/browse/JDK-8226286 <https://bugs.openjdk.java.net/browse/JDK-8226286>
> http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r1/ <http://cr.openjdk.java.net/~tvaleev/webrev/8226286/r1/>
> 
> I left dangling javadoc in-place in the same way as it's done in
> java.lang.Long.

I don’t know whether this was intentional per some policy or an oversight.

> Also I removed redundant reassignment of parameter like s =
> Objects.requireNonNull(s).
> 
> By the way I noticed that remaining methods formatUnsignedInt
> and formatUnsignedIntUTF16 always accept offset = 0. Probably it would be
> good to inline offset parameter?

Yes at it is always zero.

Thanks,

Brian


More information about the core-libs-dev mailing list