RFR [14] 8226303: Examine the HttpRequest.BodyPublishers for exception handling

Daniel Fuchs daniel.fuchs at oracle.com
Tue Jun 18 18:36:49 UTC 2019


Hi Pavel,

Mostly looks good to me.

One remark about the test:

  107         CompletableFuture<Throwable> future() {
  108             return f.copy();
  109         }

I had to read the javadoc to convince myself that this was OK ;-)

If the existing tests all pass reliably you have my review.

best regards,

-- daniel

On 18/06/2019 14:22, Pavel Rappo wrote:
> Hello,
> 
> Please review the following change:
> 
>   http://cr.openjdk.java.net/~prappo/8226303/webrev.00
> 
> This change increases robustness of convenience BodyPublishers by going the
> extra mile and ensuring unlikely thrown exceptions are relayed downstream.
> 
> Thanks,
> -Pavel
> 



More information about the core-libs-dev mailing list