RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target
Andy Herrick
andy.herrick at oracle.com
Wed Jun 19 18:15:56 UTC 2019
On 6/19/2019 2:08 PM, Alexey Semenyuk wrote:
> http://cr.openjdk.java.net/~herrick/8225428/webrev.01/test/jdk/tools/jpackage/JPackageMissingArgumentsTest.java.sdiff.html:
>
> ---
> private static final String [] RESULT_7 = {"--module-path",
> "--runtime-image", "app-image"};
> ---
> Should it be "--app-image"?
yes - there is no need for a change here, either will work (since
checking code uses String.contains()) but will revert in the next revision.
/Andy
>
> - Alexey
>
> On 6/19/2019 1:34 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>> repository (jpackage).
>>
>> JDK-8225428: CLI change to remove "mode", rename to "package", and
>> build only one target
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8225428
>>
>> [2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/
>> <http://cr.openjdk.java.net/%7Eherrick/8225428/>
>>
>> /Andy
>>
>
More information about the core-libs-dev
mailing list