RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

Andy Herrick andy.herrick at oracle.com
Wed Jun 19 22:30:19 UTC 2019



On 6/19/2019 6:26 PM, Alexander Matveev wrote:
> Hi Andy,
>
> 1) Looks like you forgot to update HelpResources_ja.properties and 
> HelpResources_zh_CN.properties.
Yes I need to re-run my script to update these.
>
> 2) 
> http://cr.openjdk.java.net/~herrick/8225428/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties.frames.html
> Line 84: Error: creating app-image requires
> Should we change it to "Error: Creating application image requires", 
> since we do not have app-image option anymore?
yes - will fix .
/Andy
>
> Otherwise looks fine.
>
> Thanks,
> Alexander
>
>
> On 6/19/2019 10:34 AM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> JDK-8225428: CLI change to remove "mode", rename to "package", and 
>> build only one target
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8225428
>>
>> [2] http://cr.openjdk.java.net/~herrick/8225428/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Eherrick/8225428/>
>>
>> /Andy
>>
>



More information about the core-libs-dev mailing list