RFR 8226518: Typo in the ConnectionBuilder javadoc examples

Lance Andersen lance.andersen at oracle.com
Thu Jun 20 14:59:08 UTC 2019


Hi all

Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8226518, which addresses a typo in  the ConnectionBuilder classes.

——————
$ hg diff
diff -r c439c469e803 src/java.sql/share/classes/java/sql/ConnectionBuilder.java
--- a/src/java.sql/share/classes/java/sql/ConnectionBuilder.java	Tue Jun 18 17:50:33 2019 -0400
+++ b/src/java.sql/share/classes/java/sql/ConnectionBuilder.java	Thu Jun 20 10:51:48 2019 -0400
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -44,8 +44,8 @@
  *     Connection con = ds.createConnectionBuilder()
  *                       .user("rafa")
  *                       .password("tennis")
- *                       .setShardingKey(shardingKey)
- *                       .setSuperShardingKey(superShardingKey)
+ *                       .shardingKey(shardingKey)
+ *                       .superShardingKey(superShardingKey)
  *                       .build();
  * }</pre>
  *
diff -r c439c469e803 src/java.sql/share/classes/javax/sql/PooledConnectionBuilder.java
--- a/src/java.sql/share/classes/javax/sql/PooledConnectionBuilder.java	Tue Jun 18 17:50:33 2019 -0400
+++ b/src/java.sql/share/classes/javax/sql/PooledConnectionBuilder.java	Thu Jun 20 10:51:48 2019 -0400
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -47,8 +47,8 @@
  *     PooledConnection con = ds.createPooledConnectionBuilder()
  *                       .user("rafa")
  *                       .password("tennis")
- *                       .setShardingKey(shardingKey)
- *                       .setSuperShardingKey(superShardingKey)
+ *                       .shardingKey(shardingKey)
+ *                       .superShardingKey(superShardingKey)
  *                       .build();
  * }</pre>
  *
diff -r c439c469e803 src/java.sql/share/classes/javax/sql/XAConnectionBuilder.java
--- a/src/java.sql/share/classes/javax/sql/XAConnectionBuilder.java	Tue Jun 18 17:50:33 2019 -0400
+++ b/src/java.sql/share/classes/javax/sql/XAConnectionBuilder.java	Thu Jun 20 10:51:48 2019 -0400
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -47,8 +47,8 @@
  *     XAConnection con = ds.createXAConnectionBuilder()
  *                       .user("rafa")
  *                       .password("tennis")
- *                       .setShardingKey(shardingKey)
- *                       .setSuperShardingKey(superShardingKey)
+ *                       .shardingKey(shardingKey)
+ *                       .superShardingKey(superShardingKey)
  *                       .build();
  * }</pre>
  *
ljanders-mac:open ljanders$ 

————————

Best
Lance
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list