RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

[Andy Herrick]

looks good

/Andy


On 6/28/2019 10:03 PM, Alexander Matveev wrote:
> Hi,
>
> http://cr.openjdk.java.net/~almatvee/8224486/webrev.01/
>
> - Original fix was missing (not sure why) setting Java options map 
> flag to allow duplicates. Without it fix does not work. See 
> OrderedMap.h line 92 and 261 and Package.cpp.
> - Old loop is kept to avoid possible regression in case if we want to 
> add values from OrderedMap which does not have duplicates flag set to 
> true.
>
> Thanks,
> Alexander
>
> On 6/26/2019 7:21 AM, Andy Herrick wrote:
>> then I'm fine with original fix.
>>
>> /Andy
>>
>>
>> On 6/25/2019 6:08 PM, Alexander Matveev wrote:
>>> Hi Alexey,
>>>
>>> I cannot use index to get items from map. At least I did not figure 
>>> it out how to do this. We need to use iterator when getting values 
>>> from map.
>>>
>>> Thanks,
>>> Alexander
>>>
>>> On 6/25/2019 4:52 AM, Alexey Semenyuk wrote:
>>>> In 
>>>> http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/src/jdk.jpackage/share/native/libapplauncher/JavaVirtualMachine.cpp.sdiff.html, 
>>>> JavaOptions::AppendValues(), why do we need branching based on the 
>>>> result of Values.GetAllowDuplicates()? Why can't we use the same 
>>>> logic that was introduced by your patch to read values from the map 
>>>> in which duplicate keys are not allowed?
>>>>
>>>> - Alexey
>>>>
>>>> On 6/24/2019 9:18 PM, Alexander Matveev wrote:
>>>>> Please review the jpackage fix for bug [1] at [2].
>>>>>
>>>>> This is a fix for the JDK-8200758-branch branch of the open 
>>>>> sandbox repository (jpackage).
>>>>>
>>>>> - Duplicated Java options were not read correctly from OrderedMap, 
>>>>> instead we read only unique from map. Fixed by reading duplicated 
>>>>> Java options.
>>>>>
>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8224486
>>>>> [2] http://cr.openjdk.java.net/~almatvee/8224486/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> Alexander
>>>>
>>>
>>
>