RFR(jdk 13/java.xml) 8219705: Wrong media-type for a given serialization method

[Lance Andersen]

> On Mar 11, 2019, at 3:15 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
> 
> 
> 
> On 3/11/19, 11:54 AM, Lance Andersen wrote:
>> 
>> Hi Joe,
>> 
>>> On Mar 11, 2019, at 2:41 PM, Joe Wang <huizhe.wang at oracle.com <mailto:huizhe.wang at oracle.com>> wrote:
>>> 
>>> Thanks Lance!
>>> 
>>> The assertEquals message adds the name (prNames[i]) of the property (e.g. media-type) so that it shows "java.lang.AssertionError: media-type expected [text/html] but found [text/xml]" when fail.
>> 
>> Yep, I saw that, just my personal taste I sometimes like a bit more that is why I just mentioned it, it is all good either way :-)
> 
> I added a msg so that it displays in a bit detail in case of a failure, e.g.:
> java.lang.AssertionError: The value of the property 'media-type' should be 'text/html' when the method is 'html'. 
>  expected [text/html] but found [text/xml]
> 
> How does that sound?
works for me
> 
> -Joe
> 
>> 
>>> There's also a debug message that displays all of the properties when the test passes:
>>> method: actual: html, expected: html
>>> version: actual: 4.0, expected: 4.0
>>> indent: actual: yes, expected: yes
>>> media-type: actual: text/html, expected: text/html
>>> 
>>> Best,
>>> Joe
>>> 
>>> On 3/11/19, 11:31 AM, Lance Andersen wrote:
>>>> 
>>>> Hi Joe
>>>> 
>>>> I think this is fine.  I might consider beefing up the test assertEquals  message  it is just the name
>>>> 
>>>> Assert.assertEquals(value, prValues[i], prNames[i]);
>>>> 
>>>> 
>>>> HTH
>>>> 
>>>> Best
>>>> Lance
>>>>> On Mar 11, 2019, at 2:22 PM, Joe Wang <huizhe.wang at oracle.com <mailto:huizhe.wang at oracle.com>> wrote:
>>>>> 
>>>>> Please review a fix for a JCK failure. All XML-related JCK and SQE tests passed after the patch.
>>>>> 
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8219705 <https://bugs.openjdk.java.net/browse/JDK-8219705>
>>>>> webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8219705/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk13/8219705/webrev/>
>>>>> 
>>>>> Thanks,
>>>>> Joe
>>>>> 
>>>> 
>>>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering 
>>>> 1 Network Drive 
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>> 
>>>> 
>>>> 
>> 
>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>