RFR 8220252: Fix Headings in java.naming

Daniel Fuchs daniel.fuchs at oracle.com
Wed Mar 13 19:05:04 UTC 2019


Hi Lance,

http://cr.openjdk.java.net/~lancea/8220252/webrev.00/src/java.naming/share/classes/javax/naming/ldap/LdapContext.java.frames.html

It looks like
  78  * <h2>Context Request Controls</h2>
  100  * <h2>Connection Request Controls</h2>
  136  * <h2>Service Provider Requirements</h2>

should be <h3> - it seems they are all logical subsections
of
   53  * <h2>Request Controls</h2>

Otherwise looks good!

best regards,

-- daniel

On 13/03/2019 18:55, Lance Andersen wrote:
> Hi all
> 
> Please review the fix for 8220252,  to address the javadoc header issues [1] in java.naming
> 
> The webrev can be found at: http://cr.openjdk.java.net/~lancea/8220252/webrev.00/index.html
> 
> 
> Best
> Lance
> 
> [1] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002671.html
> 
> 



More information about the core-libs-dev mailing list