RFR 6307456 : UnixFileSystem_md.c use of chmod() and access() should handle EINTR signal appropriately (unix)

Brian Burkhalter brian.burkhalter at oracle.com
Thu Mar 14 18:16:10 UTC 2019


Hello Ivan,

This looks all right to me.

Thanks,

Brian

> On Mar 14, 2019, at 10:29 AM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
> 
> Not all the man pages agree that chmod, access and statvfs64 can be interrupted, but at least on some platforms they are allowed to fail with EINTR:  chmod(2) on MacOS, access(2) on Solaris and statvfs(3) on Linux.
> 
> So, it would be more accurate to wrap these up into a RESTARTABLE loop.
> 
> Also, java_io_UnixFileSystem_list was tiny-optimized to avoid unnecessary reallocation.
> 
> Would you please help review the fix?
> 
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-6307456 <https://bugs.openjdk.java.net/browse/JDK-6307456>
> WEBREV: http://cr.openjdk.java.net/~igerasim/6307456/00/webrev/ <http://cr.openjdk.java.net/~igerasim/6307456/00/webrev/>


More information about the core-libs-dev mailing list