8219196: DataOutputStream.writeUTF may throw unexpected exceptions

Martin Buchholz martinrb at google.com
Fri Mar 15 22:13:29 UTC 2019


Looks good to me.

On Fri, Mar 15, 2019 at 2:06 PM Brian Burkhalter <
brian.burkhalter at oracle.com> wrote:

> Updated: http://cr.openjdk.java.net/~bpb/8219196/webrev.01/
>
> On Mar 15, 2019, at 1:05 PM, Brian Burkhalter <brian.burkhalter at oracle.com>
> wrote:
>
> On Mar 15, 2019, at 12:57 PM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Looks ok.
>
> In the test, you could probably create the string using.
>    "\u0800".repeat(size);
>
>
> Good idea.
>
> Instead of disabling the test statically, you could make it conditional
> on Runtime.maxMemory but the test will fail quickly anyway.
>
>
> For this I simply added the requirement to the jtreg tags instead.
>
> DataOutputStream.java:
>
> Can you fix the indent lines 387-389, it seems to be only 3 chars.
>
>
> Will do.
>
>
> Thanks,
>
> Brian
>


More information about the core-libs-dev mailing list