RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields

Mandy Chung mandy.chung at oracle.com
Wed Mar 20 05:08:37 UTC 2019


Hi Adam,

I imported your patch but there is one test failure:
 
test/jdk/java/lang/invoke/VarHandles/accessibility/TestFieldLookupAccessibility.java

This test needs update of this change.  Can you please send an updated
patch and run all test/jdk/java/lang/invoke tests.

Mandy

On 3/6/19 8:28 AM, Adam Farley8 wrote:
> Hi Mandy,
> 
> The webrev has been updated with the new test:
> http://cr.openjdk.java.net/~afarley/8216558/webrev/
> 
> Note that I included a handful of small improvements, and that the final
> fields are all setAccessible by default, because (a) it seemed cleaner
> than adding a new control bit, and (b) nobody is meant to be changing
> final fields anyway.
> 
> Open for review.
> 
> Best Regards
> 
> Adam Farley
> IBM Runtimes


More information about the core-libs-dev mailing list