RFR: 8174222: LambdaMetafactory: validate inputs and improve documentation
Mandy Chung
mandy.chung at oracle.com
Thu Mar 21 05:22:51 UTC 2019
On 3/20/19 9:03 PM, Dan Smith wrote:
> http://cr.openjdk.java.net/~dlsmith/8174222/webrev.00/
AbstractValidatingLambdaMetafactory.java
+ throw new LambdaConversionException("implementation is not direct or
cannot be cracked"); It may help to print implementation method handle:
throw new LambdaConversionException(implementation + " is not direct or
cannot be cracked");
If you mind the formatting, the text descripting @param seems
to be aligned with the first word in the description above it.
I don't know if the webrev shows the whitespace properly
you may want to check out line 90-93.
Where does SecurityException get thrown?
I think this needs a CSR. metafactory and altMetafactory @throws
IAE, NPE and SecurityException.
The class description of LambdaMetafactory also promotes @implNote to the spec.
Otherwise looks good.
Mandy
More information about the core-libs-dev
mailing list