RFR: JDK-8215019: Allow --install-dir on windows

Andy Herrick andy.herrick at oracle.com
Thu Mar 21 17:08:53 UTC 2019

I think you missed HelpResources_zh_CN.properties

I think wording of help text: 'sub-path of the installation location of 
the application such as"Program Files" or "AppData"' is  misleading.  It 
reads like "Program files" or "AppDAta" are examples of the sub-path.

The error message says: 'sub-path under default installation location" 
which is a little better. (though there should be a "the" before default).


On 3/20/2019 8:05 PM, Alexander Matveev wrote:
> Please review the jpackage fix for bug [1] at [2].
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
> - Added support for --install-dir on Windows. It should be relative 
> path to "Program Files" or "AppData".
> - If --install-dir is invalid we will use app name instead.
> - Added two new tests to validate --install-dir and related 
> functionality.
> [1] https://bugs.openjdk.java.net/browse/JDK-8215019
> [2] http://cr.openjdk.java.net/~almatvee/8215019/webrev.00/
> Thanks,
> Alexander

More information about the core-libs-dev mailing list