RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields

[Joe Darcy]

A quick comment below...

On 3/22/2019 4:33 AM, Adam Farley8 wrote:
> Hi Mandy,
>
> Answers below. :)
>
> Mandy Chung <mandy.chung at oracle.com> wrote on 22/03/2019 00:35:00:
>
>> From: Mandy Chung <mandy.chung at oracle.com>
>> To: Adam Farley8 <adam.farley at uk.ibm.com>
>> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
>> Date: 22/03/2019 00:35
>> Subject: Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails
>> to throw IllegalAccessException for final fields
>>
>>   217                 //If this is a USA test, then only the fraction
>> of the expected failures will occur; those which are both static and
> final.
>>   218                 if (fl !=
>> FieldLookup.MH_UNREFLECT_SETTER_ACCESSIBLE &&
>> actualFieldNames.stream().anyMatch(s->!(s.contains("static")&&
>> (s.contains("final")))))
>>
>> What is a USA test?
> UNREFLECT_SETTER_ACCESSIBLE.
>
> I was trying to be brief, and I lost readability.
>
> Will re-upload with the expanded name.

Please update distinct versions of a webrev (e.g. distinguished with .1, 
.2 directory names) rather than overwriting a single one. This make it 
easier for those coming to the review thread later to see the evolution 
of the changes over time.

Cheers,

-Joe