RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields

Joe Darcy joe.darcy at oracle.com
Fri Mar 22 17:06:38 UTC 2019

On 3/22/2019 9:56 AM, Mandy Chung wrote:
> Hi Adam,
> On 3/22/19 8:40 AM, Joe Darcy wrote:
>> Please update distinct versions of a webrev (e.g. distinguished with 
>> .1, .2 directory names) rather than overwriting a single one. This 
>> make it easier for those coming to the review thread later to see the 
>> evolution of the changes over time.
> +1
> I had requested new test in the webrev during my review. That really 
> helps me, a reviewer, to keep track what has been changed easily.  It 
> will also give you an idea how many revisions this review involves 
> when you started for a code review (as opposed to asking for "how to 
> fix this issue").
> I was asked to read the regression test that is attached to JBS issue [1]
> I was asked to review a diff (cut-n-paste) on the mail when I 
> requested a webrev to include a regression test. [2]
> On Jan 31, 2019 [3], I includeed a link to the OpenJDK developer guide 
> and I was hoping you read the guideline and be familiar with it which 
> should help you contributing to the OpenJDK.
> I was disappointed to get your conclusion:
>> Historically, the bigger the change I propose, the more months it takes
>> the OpenJDK community to approve.

OpenJDK is a community one participates in, not a service one sits in 
judgement over.


More information about the core-libs-dev mailing list