RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

Alan Bateman Alan.Bateman at oracle.com
Fri Mar 22 19:36:33 UTC 2019


On 22/03/2019 14:37, Baesken, Matthias wrote:
> Hello, here is   the new webrev .
>
> I  took over and adjusted  coding from       os::open  +  create_unc_path   functions   in os_windows.cpp   in hotspot  :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.0/webrev/
>
This looks quite good. For the comment then it might be better to drop 
the mention of os_windows.cpp, also maybe mention that the memory should 
be freed with JLI_MemFree rather than free.

-Alan


More information about the core-libs-dev mailing list