Request for sponsor: JDK-8221430: StringBuffer(CharSequence) constructor truncates when -XX:-CompactStrings specified

[Ivan Gerasimov]

Hi Andrew!

Thanks for finding this bug!

Your fix solves the problem.

However, I think the main issue is that the constructor 
AbstractStringBuilder(byte,int,int) is now broken:  as you discovered, 
it allows to create a string buffer with the coder LATIN1 when 
COMPACT_STRINGS is false.

Wouldn't it make sense to rename the argument of the constructor to, 
say, coderHint, and then either use it as the coder if 
COMPACT_STRINGS==true, or discard it otherwise.

What do you think?

With kind regards,
Ivan

On 3/25/19 12:45 PM, Andrew Leonard wrote:
> Hi,
> Please can I request a sponsor for this fix to a JDK-13 regression?
>
> Patch with jtreg testcase here:
> http://cr.openjdk.java.net/~aleonard/8221430/webrev.00/
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8221430
>
> Many thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> Phone internal: 245913, external: 01962 815913
> internet email: andrew_m_leonard at uk.ibm.com
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>

-- 
With kind regards,
Ivan Gerasimov