RFR(xs): 8221375: Windows 32bit build (VS2017) broken

[Thomas Stüfe]

On Mon, Mar 25, 2019 at 10:49 PM Martijn Verburg <martijnverburg at gmail.com>
wrote:

> Hi all,
>
> Snipping much, but commenting on one statement inline below.
>
> On Mon, 25 Mar 2019 at 01:58, David Holmes <david.holmes at oracle.com>
> wrote:
>
>> Hi Thomas,
>>
>> A few queries, comments and concerns ...
>>
>> On 25/03/2019 6:58 am, Thomas Stüfe wrote:
>> > Hi all,
>> >
>> > After a long time I tried to build a Windows 32bit VM (VS2017) and
>> failed;
>>
>> I'm somewhat surprised as I thought someone was actively doing Windows
>> 32-bit builds out there, plus there are shared code changes that should
>> also have been caught by non-Windows 32-bit builds. :(
>>
>
> AdoptOpenJDK is building Win-32 but we only recently swapped to VS2017 to
> do so and have hit the same issues (Thomas beat us to reporting!).
>
>
Still curious what you actually build, since I believe not all of the
issues are related to vs2017.

Do you build release only or also debug? Do you build with
warnings-as-errors disabled?


> Hopefully, we'll have that nightly warning system in place for you going
> forward soon.
>
>
That would be helpful.

Cheers, Thomas


> Cheers,
> Martijn
>