RFR: 8221473: Configuration::reads can use Set.copyOf
Alan Bateman
Alan.Bateman at oracle.com
Tue Mar 26 13:54:17 UTC 2019
On 26/03/2019 13:44, Claes Redestad wrote:
>
> Or with this less verbose comment (suggested offline by Alan):
>
> diff -r 5ee30b6991a7
> src/java.base/share/classes/java/lang/module/Configuration.java
> --- a/src/java.base/share/classes/java/lang/module/Configuration.java
> Mon Dec 03 16:25:27 2018 +0100
> +++ b/src/java.base/share/classes/java/lang/module/Configuration.java
> Tue Mar 26 14:50:55 2019 +0100
> @@ -575,7 +575,8 @@
> }
>
> Set<ResolvedModule> reads(ResolvedModule m) {
> - return Collections.unmodifiableSet(graph.get(m));
> + // The sets stored in the graph are already immutable sets
> + return Set.copyOf(graph.get(m));
> }
This looks good.
-Alan
More information about the core-libs-dev
mailing list