RFR (XS) 8221401: [TESTBUG] java/math/BigInteger/LargeValueExceptions.java should be disabled on 32-bit platforms

Thomas Stüfe thomas.stuefe at gmail.com
Tue Mar 26 16:26:55 UTC 2019


Looks fine and trivial.

..Thomas

On Tue, Mar 26, 2019 at 2:02 PM Aleksey Shipilev <shade at redhat.com> wrote:

> Ping, no takers?
>
> -Aleksey
>
> On 3/25/19 3:33 PM, Aleksey Shipilev wrote:
> > Bug:
> >   https://bugs.openjdk.java.net/browse/JDK-8221401
> >
> > My major concern is to make tier1 passing on x86_32. This is one of the
> tests that fail. Smaller
> > heap size does not fit this test case, unfortunately. So, we have to
> disable it for 32-bit builds.
> > In fact, somebody did it already for 8u backport, but not upstream!
> >
> > Fix:
> >
> > diff -r 59816a32df2c
> test/jdk/java/math/BigInteger/LargeValueExceptions.java
> > --- a/test/jdk/java/math/BigInteger/LargeValueExceptions.java   Mon Mar
> 25 13:12:37 2019 +0100
> > +++ b/test/jdk/java/math/BigInteger/LargeValueExceptions.java   Mon Mar
> 25 15:29:16 2019 +0100
> > @@ -23,11 +23,11 @@
> >
> >  /*
> >   * @test
> >   * @bug 8200698
> >   * @summary Tests that exceptions are thrown for ops which would
> overflow
> > - * @requires os.maxMemory >= 4g
> > + * @requires (sun.arch.data.model == "64" & os.maxMemory >= 4g)
> >   * @run testng/othervm -Xmx4g LargeValueExceptions
> >   */
> >  import java.math.BigInteger;
> >  import static java.math.BigInteger.ONE;
> >  import org.testng.annotations.Test;
> >
> >
> > Testing: Linux {x86_64, x86_32} fastdebug build and test, jdk-submit
> (running)
> >
> > Thanks,
> > -Aleksey
> >
>
>
> --
> Thanks,
> -Aleksey
>
> -------------------
> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
> Commercial register: Amtsgericht Muenchen, HRB 153243,
> Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric
> Shander
>
>


More information about the core-libs-dev mailing list