RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

[Baesken, Matthias]

Hello could you please look into it ?

Best regards, Matthias



> -----Original Message-----
> From: Baesken, Matthias
> Sent: Montag, 25. März 2019 18:05
> To: Langer, Christoph <christoph.langer at sap.com>
> Cc: 'core-libs-dev at openjdk.java.net' <core-libs-dev at openjdk.java.net>;
> 'Alan Bateman' <Alan.Bateman at oracle.com>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
> 
> Hello here is an updated webrev :
> 
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.1/webrev/
> 
> 
> 
> > > In  JLI_Open(const char* name, int flags), you should remove ret and only
> > > use fd, I think.
> 
> 
> I removed ret  and adjusted some comments.
> 
> Additionally I added a  test  that uses (on Windows)     JLI_Open  on  a  jar file
> with a "long"   path  (> 260 chars).
>  [ JLI_Open  is currently called  from  parse_manifest.c  with jarfile as
> parameter ]
>