RFR: 8216539: tools/jar/modularJar/Basic.java timed out

[Mandy Chung]

On 3/27/19 4:56 PM, Lance Andersen wrote:
> Hi Mandy,
>
>
>> On Mar 27, 2019, at 7:23 PM, Mandy Chung <mandy.chung at oracle.com 
>> <mailto:mandy.chung at oracle.com>> wrote:
>>
>> Hi Lance,
>>
>> Do you understand what takes so long for this test to run?
>
> Well it is executing a lot of jar commands.  I did not see anything 
> that sticks out in the failed logs that point to anything obvious.

One thing you could do is to instrument the test to gather the timing 
statistics.

>> Is it running fastdebug and -Xcomp or other flag?
>
> It is just a standard windows run.

This is even strange if it's running normal product build.

Mandy

>>
>> Mandy
>>
>> On 3/27/19 1:55 PM, Lance Andersen wrote:
>>> Hi all ,
>>>
>>> Please review this fix forhttps://bugs.openjdk.java.net/browse/JDK-8216539  which increases the timeout value for this test which fails once in a blue moon on windows.
>>>
>>>
>>> ———————
>>> $ hg diff
>>> diff -r dc66ada06693 test/jdk/tools/jar/modularJar/Basic.java
>>> --- a/test/jdk/tools/jar/modularJar/Basic.java	Tue Mar 26 15:36:19 2019 -0700
>>> +++ b/test/jdk/tools/jar/modularJar/Basic.java	Wed Mar 27 16:50:53 2019 -0400
>>> @@ -54,7 +54,7 @@
>>>    *        jdk.test.lib.util.FileUtils
>>>    *        jdk.test.lib.JDKToolFinder
>>>    * @compile Basic.java
>>> - * @run testng Basic
>>> + * @run testng/timeout=300 Basic
>>>    * @summary Tests for plain Modular jars & Multi-Release Modular jars
>>>    */
>>>   
>>>
>>> ——————————
>>>
>>> Best
>>> Lance
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com  <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>>
>>>
>>>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> Lance.Andersen at oracle.com  <mailto:Lance.Andersen at oracle.com>
>>>
>>>
>>>
>>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>