RFR: 8218547: Simplify JLI_Open on Windows in native code (libjli) - was : RE: RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

[Baesken, Matthias]

Thanks.   Alan, are you fine with the current webrev, if yes may I add you as reviewer ?

Best regards, Matthias


> -----Original Message-----
> From: Langer, Christoph
> Sent: Donnerstag, 28. März 2019 12:41
> To: Baesken, Matthias <matthias.baesken at sap.com>
> Cc: core-libs-dev at openjdk.java.net; Alan Bateman
> <Alan.Bateman at oracle.com>
> Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
> 
> Hi Matthias,
> 
> this looks good to me now. Let's wait for another review then.
> 
> Best regards
> Christoph
> 
> > -----Original Message-----
> > From: Baesken, Matthias
> > Sent: Donnerstag, 28. März 2019 12:39
> > To: Langer, Christoph <christoph.langer at sap.com>
> > Cc: core-libs-dev at openjdk.java.net; Alan Bateman
> > <Alan.Bateman at oracle.com>
> > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> > parse_manifest.c on windows
> >
> > Hello  here is another webrev ,   I  adjusted
> > test/jdk/tools/launcher/Arrrghs.java   a bit  taking your suggestions into
> > account .
> > Can I have a second review please ?
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.2/webrev/
> >
> > > As for the test, I think you could also check a jar in a short path
> >
> > There exist  already quite a few tests  using "-jar  some.jar"   with "normal"
> /
> > shorter paths   in  test/jdk/tools/launcher/Arrrghs.java    .
> >
> >
> > Regards, Matthias
> >
> >
> > > -----Original Message-----
> > > From: Langer, Christoph
> > > Sent: Donnerstag, 28. März 2019 11:59
> > > To: Baesken, Matthias <matthias.baesken at sap.com>
> > > Cc: core-libs-dev at openjdk.java.net; Alan Bateman
> > > <Alan.Bateman at oracle.com>
> > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> > > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> > > parse_manifest.c on windows
> > >
> > > Hi Matthias,
> > >
> > > the change to src/java.base/windows/native/libjli/java_md.c looks good
> to
> > > me now.
> > >
> > > As for the test, I think you could also check a jar in a short path to exercise
> > > both cases in JLI_Open.
> > >
> > > And a few nits:
> > > Line 506: better do:
> > > Path pelp = pcreated.resolve(elp.jar);
> > >
> > > Line 507:
> > > 2 spaces are one too much after elp
> > >
> > > Line 508:
> > > Insert 2 additional spaces in the source code string, a space between "){"
> > and
> > > another in the end after the ; of the System.out.println statement, like
> this:
> > > createJar(elp, new File("Foo"), "public static void main(String[] args) {
> > > System.out.println(\"Hello from ELP\"); }");
> > >
> > > You could also do a little cleanup: Remove method     private static String
> > > removeExtraQuotes(String in) { from line 64. It seems, it is not needed.
> > >
> > > Best regards
> > > Christoph
> > >
> > > > -----Original Message-----
> > > > From: Baesken, Matthias
> > > > Sent: Mittwoch, 27. März 2019 18:05
> > > > To: Langer, Christoph <christoph.langer at sap.com>
> > > > Cc: core-libs-dev at openjdk.java.net; Alan Bateman
> > > > <Alan.Bateman at oracle.com>
> > > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native code
> > > > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> > > > parse_manifest.c on windows
> > > >
> > > > Hello could you please look into it ?
> > > >
> > > > Best regards, Matthias
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Baesken, Matthias
> > > > > Sent: Montag, 25. März 2019 18:05
> > > > > To: Langer, Christoph <christoph.langer at sap.com>
> > > > > Cc: 'core-libs-dev at openjdk.java.net' <core-libs-
> > dev at openjdk.java.net>;
> > > > > 'Alan Bateman' <Alan.Bateman at oracle.com>
> > > > > Subject: RE: RFR: 8218547: Simplify JLI_Open on Windows in native
> code
> > > > > (libjli) - was : RE: RFR : 8217093: Support extended-length paths in
> > > > > parse_manifest.c on windows
> > > > >
> > > > > Hello here is an updated webrev :
> > > > >
> > > > >
> > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218547.1/webrev/
> > > > >
> > > > >
> > > > >
> > > > > > > In  JLI_Open(const char* name, int flags), you should remove ret
> > and
> > > > only
> > > > > > > use fd, I think.
> > > > >
> > > > >
> > > > > I removed ret  and adjusted some comments.
> > > > >
> > > > > Additionally I added a  test  that uses (on Windows)     JLI_Open  on  a
> > jar
> > > > file
> > > > > with a "long"   path  (> 260 chars).
> > > > >  [ JLI_Open  is currently called  from  parse_manifest.c  with jarfile as
> > > > > parameter ]
> > > > >