RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Andy Herrick andy.herrick at oracle.com
Thu May 2 20:27:19 UTC 2019


Semyon:

Although we removed --mac-app-store-entitlements and 
--mac-app-store-category options from help text, and disabled the 
mac-app-store target (so these two options have no effect) when we 
decided to drop support for this in the the initial release, we never 
actually removed the options, or the (now dead) code behind them.  At 
the very least we should have removed them from ValidOptions, but it 
will be cleaner to remove them entirely.

Please file a bug to address this.

/Andy




On 5/2/2019 1:39 PM, semyon.sadetsky at oracle.com wrote:
> The --mac-app-store-entitlements option was only used for the Mac App 
> Store deployment. Since it is not supported anymore this option is not 
> used anywhere and need to be removed.
>
> Also the jdk.jpackage.internal. MacAppStoreBundler class and related 
> resources are the dead code.
>
> --Semyon
>
> On 4/24/19 5:44 PM, Andy Herrick wrote:
>> Please review  changes for [1] which is the implementation bug for 
>> JEP-343.
>>
>> The webrev at [2] is the total cumulative webrev of changes for the 
>> jpackage tool, currently in the JDK-8200758-branch branch of the open 
>> sandbox repository.
>>
>> The webrev at [3] shows the changes from EA-05 to EA-06.
>>
>> The latest EA-6 (build 49) is posted at [4].
>>
>> Please send feedback to core-libs-dev at openjdk.java.net
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8200758
>>
>> [2] http://cr.openjdk.java.net/~herrick/8212780/webrev.05-06/
>>
>> [3] http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/
>>
>> [4] http://jdk.java.net/jpackage/
>>
>>
>> /Andy
>>
>>
>



More information about the core-libs-dev mailing list