RFR (CSR) - JDK-8218285 ClassDesc should have a full name method

Jim Laskey james.laskey at oracle.com
Tue May 7 11:50:04 UTC 2019


Thank you.

> On May 7, 2019, at 8:45 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> Looks good - only minor quibble is that the javadoc doesn't make it crystal clear as to whether the qualified name uses dots or '/'. Should the javadoc point at the term 'canonical name', or at Class::getCanonicalName (or both) ?
> 
> https://docs.oracle.com/javase/specs/jls/se12/html/jls-6.html#jls-6.7
> 
> Note that there are examples where full qualified vs. canonical yield different results.
> 
> Maurizio
> 
> On 30/04/2019 19:41, Jim Laskey wrote:
>> I've had no takers. Please take the time. Thank you.
>> 
>> -- Jim
>> 
>> 
>>> On Apr 26, 2019, at 2:57 PM, Jim Laskey <james.laskey at oracle.com> wrote:
>>> 
>>> Please review. Thank you.
>>> 
>>> Cheers,
>>> 
>>> -- Jim
>>> 
>>> 
>>> 
>>> Summary: Add the method ClassDesc::displayFullName to return the fully qualified class name from a ClassDesc. Add a second method MethodTypeDesc::displayFullDescriptor which returns the MethodTypeDesc descriptor using fully qualified class names.
>>> 
>>> csr: https://bugs.openjdk.java.net/browse/JDK-8218285
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8212975
>>> webrev: http://cr.openjdk.java.net/~jlaskey/8212975/webrev-03/index.html
>>> 



More information about the core-libs-dev mailing list