RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc <entries20> failed 6af4413c vs 0 ...)

[Langer, Christoph]

Thanks, Lance.

From: Lance Andersen <lance.andersen at oracle.com>
Sent: Montag, 13. Mai 2019 19:00
To: Langer, Christoph <christoph.langer at sap.com>
Cc: core-libs-dev <core-libs-dev at openjdk.java.net>; nio-dev <nio-dev at openjdk.java.net>
Subject: Re: RFR(S): 8223597: jdk/nio/zipfs/ZipFSTester.java RuntimeException: CHECK_FAILED! (getAttribute.crc <entries20> failed 6af4413c vs 0 ...)

Hi Christoph,

The change seems reasonable.

On May 13, 2019, at 8:14 AM, Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>> wrote:

Hi,

please review this fix of a regression in zipfs after JDK-8222532 [0].

Bug: https://bugs.openjdk.java.net/browse/JDK-8223597
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/

The issue occurs when an empty file/channel is persisted into a zip file. The entry had already been compressed with CRC of 0 at the time the output stream to the zipfs was closed. But when the Entry is eventually synced to the zip file, this is not detected and the bytes get compressed again.

The test was adapted to reliably provoke this intermittent error. In the test I also suppressed printout of an expected Exception to avoid some distraction when reading its JTR files.

Thanks
Christoph

[0] https://bugs.openjdk.java.net/browse/JDK-8222532

[cid:image001.gif at 01D50A3E.E551EFA0]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>