Re: RFR: JDK-8223803: j.l.c.MethodTypeDesc::insertParameterTypes​ doesn't control type of parameters

[Vicente Romero]

ping

On 5/15/19 5:27 PM, Vicente Romero wrote:
> Please review fix for [1] at [2] and the related CSR at [3]. Method 
> java.lang.constant.MethodTypeDesc::insertParameterTypes​ should 
> control the type of parameters being inserted. In particular, no 
> parameter can be a class descriptor of primitive type |void|. This fix 
> is updating the spec of the mentioned method plus it is adding a test 
> to make sure that the implementation is in sync with the 
> specification. As mentioned in the CSR and apiNote has been added to 
> method j.l.c.ConstantDesc::resolveConstantDesc to clarify that a 
> method type descriptor can have more than 255 argument slots so at 
> resolution time, as a j.l.i.MethodType, errors can be thrown.
>
> Thanks,
> Vicente
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8223803
> [2] http://cr.openjdk.java.net/~vromero/8223803/webrev.00/
> [3] https://bugs.openjdk.java.net/browse/JDK-8223997