Re: RFR: JDK-8223723: j.l.c.MethodTypeDesc.dropParameterTypes​ throws the undocumented exception: IllegalArgumentException

[Roger Riggs]

Hi Vicente,

Method j.l.c.MethodTypeDesc.dropParameterTypes​ throws an exception in a 
case
I would change the CSR summary to "Method 
j.l.c.MethodTypeDesc.dropParameterTypes​ should specify 
IndexOutOfBoundsException"
to focus on the new behavior.

The link to the webrev looks ok, but has the fix for 8223725 instead.

Roger


On 05/16/2019 06:52 PM, Vicente Romero wrote:
> Hi,
>
> I still need a reviewer for this simple patch and CSR,
>
> TIA,
> Vicente
>
> On 5/14/19 4:53 PM, Vicente Romero wrote:
>> Please review fix for [1] at [2]. The implementation of method 
>> java.lang.constant.MethodTypeDesc::dropParameterTypes was throwing a 
>> non specified exception. The proposed fix is synchronizing the 
>> implementation with the specification. Please also review the CSR at 
>> [3]. Check the problem section in the CSR for more details,
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8223723
>> [2] http://cr.openjdk.java.net/~vromero/8223767/webrev.00/
>> [3] https://bugs.openjdk.java.net/browse/JDK-8223918
>