RFR: JDK-8223725: j.l.c.MethodHandleDesc::of throws undocumented exception IllegalArgumentException

[Vicente Romero]

Hi Roger,

Thanks for the review, my apologies, I made a mistake an applied the 
change to the wrong method. I have corrected the patch [1] and the CSR 
[2]. I have updated the language used as you suggested,

Thanks,
Vicente

[1] http://cr.openjdk.java.net/~vromero/8223725/webrev.01/
[2] https://bugs.openjdk.java.net/browse/JDK-8223920

On 5/17/19 2:05 PM, Roger Riggs wrote:
> Hi Vicente,
>
> What's the difference in the IAE exceptions describing IAE's as
> being "incorrect formats' vs 'is invalid' or 'not valid'?
>
> Each requires a spec for valid and invalid strings or is undefined.
>
> Can the new IAE use the same language as is used for the ofDescriptor 
> method?
> Avoiding any question about differences.
>
> 69:  Also, is the word 'lookup' overloaded?  Is 'lookup' is 
> significant in this context?
>
> Roger
>
>
> On 05/14/2019 06:37 PM, Vicente Romero wrote:
>> Please review fix [1] for [2] and the corresponding CSR at [3]. The 
>> fix is just adding a missing @throws at method 
>> j.l.c.MethodHandleDesc::of. It is a one liner fix,
>>
>> Thanks,
>> Vicente
>>
>> [1] http://cr.openjdk.java.net/~vromero/8223725/webrev.00/
>> [2] https://bugs.openjdk.java.net/browse/JDK-8223725
>> [3] https://bugs.openjdk.java.net/browse/JDK-8223920
>