Re: RFR: JDK-8223723: j.l.c.MethodTypeDesc.dropParameterTypes​ throws the undocumented exception: IllegalArgumentException

[Vicente Romero]

Hi Roger,


On 5/17/19 4:53 PM, Roger Riggs wrote:
> Hi Vicente,
>
> Looks fine.
>
> Please add a "." at the end of the summary 2nd sentence.

done

>
> BTW, are you aware of the range checking methods in 
> java.util.Objects.checkFromToIndex(from, to, length)?
> They make it easy avoid to check all the conditions on subranges.

I will take a look at them, thanks for the suggestion,
>
> Thanks, Roger

Thanks for all the reviews so far!
Vicente

>
>
> On 05/17/2019 04:14 PM, Vicente Romero wrote:
>> Hi Roger,
>>
>> Thanks again for the reviews, I have modified the CSR summary after 
>> your suggestion [1]. I have also fixed the issue with the webrev link 
>> [2],
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8223918
>> [2] http://cr.openjdk.java.net/~vromero/8223723/webrev.01/
>>
>> On 5/17/19 2:18 PM, Roger Riggs wrote:
>>> Hi Vicente,
>>>
>>> Method j.l.c.MethodTypeDesc.dropParameterTypes​ throws an exception 
>>> in a case
>>> I would change the CSR summary to "Method 
>>> j.l.c.MethodTypeDesc.dropParameterTypes​ should specify 
>>> IndexOutOfBoundsException"
>>> to focus on the new behavior.
>>>
>>> The link to the webrev looks ok, but has the fix for 8223725 instead.
>>>
>>> Roger
>>>
>>>
>>> On 05/16/2019 06:52 PM, Vicente Romero wrote:
>>>> Hi,
>>>>
>>>> I still need a reviewer for this simple patch and CSR,
>>>>
>>>> TIA,
>>>> Vicente
>>>>
>>>> On 5/14/19 4:53 PM, Vicente Romero wrote:
>>>>> Please review fix for [1] at [2]. The implementation of method 
>>>>> java.lang.constant.MethodTypeDesc::dropParameterTypes was throwing 
>>>>> a non specified exception. The proposed fix is synchronizing the 
>>>>> implementation with the specification. Please also review the CSR 
>>>>> at [3]. Check the problem section in the CSR for more details,
>>>>>
>>>>> Thanks,
>>>>> Vicente
>>>>>
>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8223723
>>>>> [2] http://cr.openjdk.java.net/~vromero/8223767/webrev.00/
>>>>> [3] https://bugs.openjdk.java.net/browse/JDK-8223918
>>>>
>>>
>>
>