RFR(s): (new approach) 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

[Thomas Stüfe]

Hi Florian,

On Mon, May 20, 2019 at 4:24 PM Florian Weimer <fweimer at redhat.com> wrote:

> * Thomas Stüfe:
>
> > Hi all,
> >
> > (old mail thread:
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-May/060139.html
> )
> >
> > May I please have your reviews and opinions for the following bug fix:
> >
> > issue: https://bugs.openjdk.java.net/browse/JDK-8223777
> > cr:
> http://cr.openjdk.java.net/~stuefe/webrevs/8223777-posix_spawn-no-exec-error-alternate-impl/webrev.00/webrev/
> >
> > ---
>
> I wonder if you should use 0 as the value for CHILD_IS_ALIVE.  All
> integers could be valid errno values.  But if you check for errors from
> the restartableWrite call (and call _exit), I don't think there is a
> risk of confusion, so the value does not have to be distinct.
>
>
I'd like to keep this value as it is (0x10000). I plan to extend this
scheme when implementing https://bugs.openjdk.java.net/browse/JDK-8224180 -
basically, have a return code which still fits into an int but is an errno
and some sort of context id and'ed together.

Cheers, Thomas

Thanks,
> Florian
>