RFR: 8224240: Properties.load fails to throw IAE on malformed unicode in certain circumstances

Daniel Fuchs daniel.fuchs at oracle.com
Tue May 21 16:40:45 UTC 2019


Thanks Claes!

Looks good.

best regards,

-- daniel

On 21/05/2019 14:12, Claes Redestad wrote:
> Hi Daniel,
> 
> On 2019-05-21 12:48, Daniel Fuchs wrote:
>> Hi Claes,
>>
>> Looks good to me. 
> 
> Thanks!
> 
>> But can you add a test for when
>> the malformed sequence is not at the end of a line,
>> and one for when it's not the first character in the
>> value?
>>
>> Something like:
>>
>>          checkMalformedUnicodeEscape("b=\\u012xyz\n");
>>          checkMalformedUnicodeEscape("b=x\\u012yz\n");
>>          checkMalformedUnicodeEscape("b=xyz\\u012\n");
> 
> seems reasonable, updated in-place.
> 
> /Claes



More information about the core-libs-dev mailing list