RFR 7061590 : Javadoc issues in Charset and StandardCharsets

[Ivan Gerasimov]

Hello!

Do you think it's good to go now?

Thanks in advance,

Ivan


On 5/20/19 12:26 PM, Ivan Gerasimov wrote:
> Thank you Jon and Alan for your suggestions!
>
> Here's the new webrev updated accordingly:
>
> http://cr.openjdk.java.net/~igerasim/7061590/01/webrev/
>
> With kind regards,
>
> Ivan
>
>
> On 5/20/19 12:03 PM, Alan Bateman wrote:
>> On 20/05/2019 19:48, Ivan Gerasimov wrote:
>>> Hello!
>>>
>>> A few small javadoc issues.
>>>
>>> The most visible one is that the last dot in abbreviation a.k.a. is 
>>> treated as a period, so the generated description appears broken 
>>> (see [1] 
>>> <https://docs.oracle.com/en/java/javase/12/docs/api/java.base/java/nio/charset/StandardCharsets.html>):
>>>
>>> static Charset    ISO_8859_1    ISO Latin Alphabet No. 1, a.k.a.
>>> static Charset    US_ASCII      Seven-bit ASCII, a.k.a.
>>> ...
>>>
>>> Would you please help review the fix?
>>>
>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-7061590
>>> WEBREV: http://cr.openjdk.java.net/~igerasim/7061590/00/webrev/
>> I agree with Jon on the a.k.a uages.
>>
>> Also Charsets puts a space after <p> so should probably keep that 
>> consistent.
>>
>> -Alan.
>>
>

-- 
With kind regards,
Ivan Gerasimov