RFR: Revert: 8216553: JrtFileSystemProvider getPath(URI) omits /modules element from file path

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Wed May 29 04:55:10 UTC 2019


Thanks Jim for pushing the reverting changeset.

PS. Sorry that I broke the build. I did run jrtfs, javac and javap 
tests. Didn't realise that faulty jrt: URIs are pervasive in tests (per 
JEP jrt: URIs should not have '/modules/' part - which is the bug fix is 
about)

-Sundar

On 29/05/19, 1:19 AM, Jim Laskey wrote:
> Thank you.
>
>> On May 28, 2019, at 4:44 PM, Joe Darcy<joe.darcy at oracle.com>  wrote:
>>
>> If this is a straight backport of the previous change, I approve the revision.
>>
>> Cheers,
>>
>> -Joe
>>
>> On 5/28/2019 12:39 PM, Jim Laskey wrote:
>>> Please review. Need to revert a change Sundar did earlier today that is causing 33 tier2 failures.
>>>
>>> Cheers,
>>>
>>> -- Jim
>>>
>>> Reverse webrev: http://cr.openjdk.java.net/~jlaskey/8224908/webrev/index.html<http://cr.openjdk.java.net/~jlaskey/8224908/webrev/index.html>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8224908<https://bugs.openjdk.java.net/browse/JDK-8224908>
>>>
>>> Job: mach5-one-jdk-13-1151-tier2-20190528-1515-2755946<http://java.se.oracle.com:10065/mdash/jobs/mach5-one-jdk-13-1151-tier2-20190528-1515-2755946>
>>> Original changset: http://hg.openjdk.java.net/jdk/jdk/rev/63ab89cc3e69<http://hg.openjdk.java.net/jdk/jdk/rev/63ab89cc3e69>


More information about the core-libs-dev mailing list