[13] RFR: 8223773: DateTimeFormatter Fails to throw an Exception on Invalid CLOCK_HOUR_OF_AMPM and HOUR_OF_AMPM

[naoto.sato at oracle.com]

Thanks, Roger.

On 5/30/19 6:55 AM, Roger Riggs wrote:
> Hi Naoto,
> 
> This looks ok.
> Typically, it is not necessary to check the exception message text.

I just wanted to make sure that the thrown DateTimeParseException is 
none other than the exception that is expected. There seems no other way 
to check that.

Naoto

> 
> Thanks, Roger
> 
> On 05/29/2019 05:21 PM, Lance Andersen wrote:
>> Hi Naoto,
>>
>> This is OK.
>>
>> Could you please add an @summary as it is missing so that we are 
>> consistent with other tests.
>>
>> No need to spin a webrev again though
>>
>>
>> Best
>> Lance
>>> On May 29, 2019, at 5:12 PM, naoto.sato at oracle.com wrote:
>>>
>>> Hi,
>>>
>>> Please review the fix for the following issue:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8223773
>>>
>>> The proposed changeset is located at:
>>>
>>> https://cr.openjdk.java.net/~naoto/8223773/webrev.00/
>>>
>>> Checking the range of HourOfAmPm with the range of AmPmOfDay is 
>>> apparently incorrect. Fixing it will change the behavior of parsing 
>>> with SMART resolver style to throw a DateTimeParseException. This is 
>>> a change in which an app will start to see an exception with 
>>> incorrect data, but that is what should be in the first place.
>>>
>>> Naoto
>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>
>