RFR: 8233291: [TESTBUG] tools/jlink/plugins/VendorInfoPluginsTest.java fails with debug VMs
Jie Fu
fujie at loongson.cn
Fri Nov 1 04:08:12 UTC 2019
Hi Mandy,
Thanks for your review and nice suggestion.
Updated: http://cr.openjdk.java.net/~jiefu/8233291/webrev.01/
I had added '@requires vm.flavor == "server"' since the test is only
suitable for server VMs.
Testing:
----------------------------------
Ben="tools/jlink/plugins/VendorInfoPluginsTest.java"
make test TEST="${Ben}" CONF=server-release
make test TEST="${Ben}" CONF=fastdebug
make test TEST="${Ben}" CONF=slowdebug
make test TEST="${Ben}" CONF=minimal
make test TEST="${Ben}" CONF=zero
----------------------------------
Please review it and give me some advice.
Thanks a lot.
Best regards,
Jie
On 2019/11/1 上午2:09, Mandy Chung wrote:
> Hi Jie,
>
> On 10/30/19 11:13 PM, Jie Fu wrote:
>> Hi all,
>>
>> May I get reviews for the small fix for the failure of
>> VendorInfoPluginsTest.java in debug VMs?
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8233291
>> Webrev: http://cr.openjdk.java.net/~jiefu/8233291/webrev.00/
>
> Thanks for fixing this.
>
> Changing the regex to ".*build.*$" is okay. Perhaps checking if
> "jdk.debug" system property is present and prepend to the regex?
>
> Mandy
More information about the core-libs-dev
mailing list