RFR: JDK-8232919: If user installs msi and exe, two installations are found in Add/Remove

[Andy Herrick]

technically - even this minuscule change in CompileJavaModules should be 
reviewed by build team.

overall this looks good.  I might agree that the variables that can be 
overridden in overrides.wxi need to be documented, possibly in a comment 
in the default overrides.wxi.

/Andy

On 11/2/2019 1:26 AM, Alexander Matveev wrote:
> Hi Alexey,
>
> On 11/1/2019 9:00 PM, Alexey Semenyuk wrote:
>>
>>
>> On 11/1/2019 9:45 PM, Alexander Matveev wrote:
>>> Hi Alexey,
>>>
>>> http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs.frames.html 
>>>
>>> This file refers to JpAllowDowngrades and JpAllowUpgrades. Code sets 
>>> JpAllowUpgrades to yes always and never sets JpAllowDowngrades. 
>>> Maybe I am missing something, but why we need these defs in .wxs 
>>> file if they do nothing.
>> We need these defs so that if people would like to customize update 
>> rules of their msi installer they can set only WiX variables instead 
>> of replacing the whole default main.wxs.
>> Say, they would like to enable downgrades in their installers and the 
>> other defaults would work for them. Then they would need to put only 
>> overrides.wxi in resource directory with the following contents:
>> <?xml version="1.0" encoding="utf-8"?>
>> <Include>
>>   <?define JpAllowDowngrades=yes ?>
>> </Include>
> Should we put help into overrides.wxi to show what can be changed. For 
> example:
> <?xml version="1.0" encoding="utf-8"?>
>  <!-- Stub by design -->
> <!-- To enable downgrades uncomment -->
> <!--  <?define JpAllowDowngrades=yes ?> -->
> <Include/>
>>
>>> Also, I think we should allow downgrades by default.
>> I don't have any particular preferences on the matter. However there 
>> are other options, like allow side-by-side installation of different 
>> versions of the same application. Should we allow this by default?
>> Whatever defaults we would pick up, they wouldn't work for all people 
>> and we need convenient way to adjust them without the need to replace 
>> the whole main.wxs.
> Agree. I think it might be good idea to keep defaults same or close as 
> possible to other platforms. macOS should allow downgrades by default 
> as far as I know. Not sure about Linux.
>
> Thanks,
> Alexander
>>
>> - Alexey
>>>
>>> Thanks,
>>> Alexander
>>>
>>> On 11/1/2019 5:06 PM, Alexey Semenyuk wrote:
>>>> Please review the jpackage fix for bug [1] at [2].
>>>>
>>>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>>>> repository (jpackage).
>>>>
>>>> Additionally:
>>>> - added support for `overrides.wxi` WiX source file in resource 
>>>> dir. Custom overrides.wxi can be used as a placeholder for 
>>>> overrides of default WiX variables defined by jpackage that control 
>>>> output msi.
>>>>
>>>> - Alexey
>>>>
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8232919
>>>>
>>>> [2] http://cr.openjdk.java.net/~asemenyuk/8232919/webrev.00
>>>>
>>>
>>
>