<i18n dev> [14] RFR: 8233579: DateFormatSymbols.getShortMonths() return wrong string on es_CL, es_CO locales
naoto.sato at oracle.com
naoto.sato at oracle.com
Thu Nov 7 02:34:31 UTC 2019
Hi Joe,
Thanks for the review! I tried to draft some comments, but thinking of
it, it could be confusing to leave a comment for a removed (wrong) code.
So instead of leaving code comments, I modified the JIRA issue
mentioning it, so that maintainers later could find out the rationale.
Naoto
On 11/6/19 6:21 PM, Joe Wang wrote:
> Looks good to me. It might be good to leave a note to the method about
> the change (e.g. why it no longer substitutes).
>
> -Joe
>
> On 11/6/19 1:45 PM, naoto.sato at oracle.com wrote:
>> Hi,
>>
>> Please review the fix to the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8233579
>>
>> The proposed changeset is located at:
>>
>> https://cr.openjdk.java.net/~naoto/8233579/webrev.00/
>>
>> The problem was in the CLDR converter where it substitutes the context
>> dependent style names with stand alone style names, if the former set
>> of names are missing in a locale bundle. Corrected to not substitute,
>> thus inherit from the parent bundles.
>>
>> Naoto
>
More information about the core-libs-dev
mailing list