RFR: JDK-8233636: Make jpackage an incubator and remove tool provider implementation

[Andy Herrick]

On 11/7/2019 5:38 PM, Alexey Semenyuk wrote:
> I guess the link for the review is 
> https://cr.openjdk.java.net/~herrick/8233636/webrev.02
>
sry: yes webrev is http://cr.openjdk.java.net/~herrick/8233636/webrev.02
> http://cr.openjdk.java.net/~herrick/8233636/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html:50 
>
> I'd suggest to replace
> ---
> if (name.equals("jpackage"))
> ---
sure, I can do that.
>
> with more robust
> ---
> if (this == JPACKAGE)
> ---
>
> http://cr.openjdk.java.net/~herrick/8233636/webrev.02/test/jdk/tools/jpackage/share/jdk/jpackage/tests/BasicTest.java.sdiff.html: 
>
> Did you drop JPackageCommand.filterOutput() calls intentionally?
>
> The rest looks good.
>
> - Alexey
>
> On 11/7/2019 4:45 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bug [1] at [2].
>>
>> This is a fix for the JDK-8200758-branch branch of the open sandbox 
>> repository (jpackage).
>>
>> This changes the module name, and base package name from jdk.jpackage 
>> to jdk.incubator.jpackage.
>>
>> This removes the "provides" statement in module-info so 
>> jdk.incubator.jpackage can not directly be discovered as a 
>> ToolProvider, but it also exports jdk.incubator.jpackage which now 
>> contains ToolProviderFactory.java which can be used for the same 
>> purpose.
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8233636
>>
>> [2] https://cr.openjdk.java.net/~herrick/8233636/webrev-02
>>
>> /Andy
>>
>