RFR: JDK-8233636: Make jpackage an incubator and remove tool provider implementation

[Mandy Chung]

On 11/7/19 1:45 PM, Andy Herrick wrote:
> Please review the jpackage fix for bug [1] at [2].
>
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
>
> This changes the module name, and base package name from jdk.jpackage 
> to jdk.incubator.jpackage.
>
> This removes the "provides" statement in module-info so 
> jdk.incubator.jpackage can not directly be discovered as a 
> ToolProvider, but it also exports jdk.incubator.jpackage which now 
> contains ToolProviderFactory.java which can be used for the same purpose.
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8233636
>
> [2] https://cr.openjdk.java.net/~herrick/8233636/webrev.02

make/common/Modules.gmk
src/java.base/share/classes/module-info.java
    - it'd be good to keep the list in alphabetical order

jdk.incubator.jpackage.ToolProviderFactory is exported and needs the 
specification and javadoc.

   34     private static ToolProvider provider = new JPackageToolProvider();

Nit: this can be final field.

Mandy