RFR: 8231863: Crash if classpath is read from @argument file and the main gets option argument

Alan Bateman Alan.Bateman at oracle.com
Fri Nov 8 10:56:26 UTC 2019


On 07/11/2019 22:55, Henry Jen wrote:
> Hi,
>
> Please review the webrev[1], contributed by Mat Carter. You can find the bug details at JBS[2]. I have reviewed and tested the fix, I still need an official review before I can push this.
>
Looks okay although in the test, the createAFile helper method could be 
replaced with Files(aFile.toPath, lines) and that would avoid the need 
to concatenate all the lines. You can specify the defaultCharset to that 
method if you need really it.

-Alan


More information about the core-libs-dev mailing list