RFR: JDK-8233591: Reorder jpackage help text to focus on package
Alexander Matveev
alexander.matveev at oracle.com
Fri Nov 8 23:14:04 UTC 2019
Looks good.
On 11/8/2019 1:31 PM, Andy Herrick wrote:
> revised [3] as per below suggestions.
>
> [3] http://cr.openjdk.java.net/~herrick/8233591/webrev.03
>
> /Andy
>
>
> On 11/8/2019 4:07 PM, Alexey Semenyuk wrote:
>> This is minor and not directly related to this change, but looks like
>> we have inconsistency in names in Sample usages.
>> Names used: modulePath, ModulePath, moduleName, className,
>> moduleName/ClassName, moduleName/className, package.ClassName,
>> inputdir, MyJar.jar, appRuntimeImage, name, <app image dir>.
>> I'd suggest the following changes if we are touching this section of
>> help anyways:
>> package.ClassName -> packageName.className
>> MyJar.jar -> myJar.jar
>> inputdir -> inputDir
>> ModulePath -> modulePath
>> moduleName/ClassName -> moduleName/className
>> <app image dir> -> appImageDir
>>
>> - Alexey
>>
>> On 11/8/2019 3:41 PM, Andy Herrick wrote:
>>> Please review the revised jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>>> repository (jpackage).
>>>
>>> This fix (webrev.02) was revised after feedback from webrev.01.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8233591
>>>
>>> [2] http://cr.openjdk.java.net/~herrick/8233591/webrev.02/
>>>
>>> /Andy
>>>
>>
More information about the core-libs-dev
mailing list