[JDK 14] RFR 8234079: ZipFileInputStreamSkipTest.java runs zero test
Lance Andersen
lance.andersen at oracle.com
Wed Nov 13 11:58:24 UTC 2019
Looks fine
> On Nov 13, 2019, at 6:11 AM, Amy Lu <amy.lu at oracle.com> wrote:
>
> java/util/zip/ZipFile/ZipFileInputStreamSkipTest.java
>
> Test runs zero test. Please review the fix.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8234079
> webrev: http://cr.openjdk.java.net/~amlu/8234079/webrev.00
>
> Thanks,
> Amy
>
> --- old/test/jdk/java/util/zip/ZipFile/ZipFileInputStreamSkipTest.java 2019-11-13 19:01:44.000000000 +0800
> +++ new/test/jdk/java/util/zip/ZipFile/ZipFileInputStreamSkipTest.java 2019-11-13 19:01:44.000000000 +0800
> @@ -105,7 +105,7 @@
> * @throws Exception If an error occurs during the test
> */
> @Test
> - private void testStoredSkip() throws Exception {
> + public void testStoredSkip() throws Exception {
> try (ZipFile zf = new ZipFile(STORED_ZIPFILE.toFile())) {
> var entries = zf.entries();
> @@ -153,7 +153,7 @@
> * @throws Exception If an error occurs during the test
> */
> @Test
> - private void testStoredNegativeSkip() throws Exception {
> + public void testStoredNegativeSkip() throws Exception {
> try (ZipFile zf = new ZipFile(STORED_ZIPFILE.toFile())) {
> var entries = zf.entries();
> @@ -198,7 +198,7 @@
> * @throws Exception If an error occurs during the test
> */
> @Test
> - private void testDeflatedSkip() throws Exception {
> + public void testDeflatedSkip() throws Exception {
> try (ZipFile zf = new ZipFile(DEFLATED_ZIPFILE.toFile())) {
> var toSkip = 5; // Bytes to Skip
> var entries = zf.entries();
> @@ -225,7 +225,7 @@
> * @throws Exception If an unexpected error occurs during the test
> */
> @Test
> - private void testDeflatedIOException() throws Exception {
> + public void testDeflatedIOException() throws Exception {
> try (ZipFile zf = new ZipFile(DEFLATED_ZIPFILE.toFile())) {
> var entries = zf.entries();
> while (entries.hasMoreElements()) {
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev
mailing list