RFR JDK-8233527: Update Lookup::hasPrivateAccess and Lookup::defineClass spec w.r.t. full power lookup

[Mandy Chung]

On 11/14/19 5:04 PM, David Holmes wrote:
> Hi Mandy,
>
> On 15/11/2019 10:51 am, Mandy Chung wrote:
>>
>>
>> On 11/14/19 8:04 AM, Mandy Chung wrote:
>>>
>>>
>>> On 11/14/19 2:33 AM, Alan Bateman wrote:
>>>> On 14/11/2019 04:57, Mandy Chung wrote:
>>>>>
>>>>> Updated in place:
>>>>>
>>>>> http://cr.openjdk.java.net/~mchung/jdk14/8233527/webrev.02/
>>>>> http://cr.openjdk.java.net/~mchung/jdk14/8233527/specdiff/
>>>> The addition of hasFullPrivilegeAccess looks okay and probably the 
>>>> right thing to do.
>>>>
>>>> For the @deprecated message on the old method it might be simpler 
>>>> to say that the method was originally designed to test PRIVATE 
>>>> access but has since changed to test full privilege access. 
>>>
>>> It was designed to test full privilege access while private access 
>>> implies full privilege access as a Lookup with private access 
>>> includes module access.
>>>
>>
>> I updated to:
>>
>> This method was originally designed to test PRIVATE access that 
>> implies full privilege access but PRIVATE access has since become 
>> independent of PRIVATE access. It is recommended to call 
>> hasFullPrivilegeAccess() instead.
>
> That doesn't read correctly: "PRIVATE" is independent of "PRIVATE" ??
>

Dunno how I got that typo :( thanks for catching it.

This method was originally designed to test PRIVATE access that implies 
full privilege access but MODULE access has since become independent of 
PRIVATE access. It is recommended to call hasFullPrivilegeAccess() instead.

Mandy

> David
>
>> http://cr.openjdk.java.net/~mchung/jdk14//8233527/specdiff/java.base/java/lang/invoke/MethodHandles.Lookup.html 
>>
>>
>> Mandy