RFR(XS): 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater()

Lance Andersen lance.andersen at oracle.com
Fri Nov 15 16:57:17 UTC 2019


Hi Volker

Lines 54.55  ArrayList<XX> foo = …

This could be changed to List<XX> foo = …  if you wanted

otherwise  I think you are good to go
> On Nov 15, 2019, at 10:41 AM, Langer, Christoph <christoph.langer at sap.com> wrote:
> 
> Hi Volker,
> 
>>> Please remove the "import java.nio.file.Files;" statement before pushing.
>>> 
>> 
>> It's needed for "Files.deleteIfExists(zipFile)" in the finally block..
> 
> Oops, you're right. It popped up in my IDE because I tested what happened when the file remained in the directory and therefore I commented that block out.
> 
> So, go for it ��
> 
> Cheers
> Christoph
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list