RFR: 8234335: Remove line break in class declaration in java.base

[Roger Riggs]

Hi Julia,

Can you recheck the edit to java/lang/invoke/ClassSpecializer.java: 544

I would think the line should be broken at the "..."

* class TopClass { ... * private static final class Species_LLI extends 
TopClass {


MemberName.java:1098
It seems like there should be some indentation of the 2nd line of the declaration:

public <NoSuchMemberExceptionextends ReflectiveOperationException>
........MemberName resolveOrFail(byte refKind, MemberName m, Class<?> lookupClass,
                          Class<NoSuchMemberException> nsmClass)

java/lang/invoke/MethodHandles.java: 3787

If we're putting "public" on the same line as the method then
it seems useful to put the /* non-public */ on the same line too.
Though I don't know we have style guidance for that.
(And elsewhere too).

Thanks, Roger

On 11/18/19 8:04 AM, Julia Boes wrote:
> Hi,
>
> This cleanup work addresses an outdated coding convention in 
> java.base. It removes the line break from a class declaration, for 
> example:
>
>     public
>     TypeNameOnNextLine
>
> becomes
>
>     public TypeNameOnSameLine
>
>
> Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8234335/webrev.00/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8234335
>
>
> Regards,
>
> Julia
>
>
>