RFR: 8234335: Remove line break in class declaration in java.base

mark.reinhold at oracle.com mark.reinhold at oracle.com
Tue Nov 19 21:48:34 UTC 2019


2019/11/19 11:17:22 -0800, john.r.rose at oracle.com:
> On Nov 19, 2019, at 4:00 AM, Lance Andersen <lance.andersen at oracle.com> wrote:
>> Seems to be a “your milage varies”.  I am fine with whatever the
>> final decision is.  However, I do believe the comment above reads
>> better and aligns the methods better.
> 
> FWIW, and as author of many of the lines being changed, I prefer that
> comment on a separate from the actual modifiers.  I think the basic
> modifier patterns are easier to recognize quickly when comments and
> annotations are separate.

Personally I prefer to place such pseudo-modifiers on the same line
as the actual modifiers, but I accept that some prefer otherwise.

When in doubt, respect the original author’s choice.

- Mark


More information about the core-libs-dev mailing list