RFR: 8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem
Langer, Christoph
christoph.langer at sap.com
Wed Nov 20 13:39:16 UTC 2019
Hi Alan,
makes sense. I’ve updated the patch: http://cr.openjdk.java.net/~clanger/webrevs/8234089.4/
Best regards
Christoph
From: Alan Bateman <Alan.Bateman at oracle.com>
Sent: Mittwoch, 20. November 2019 09:33
To: Langer, Christoph <christoph.langer at sap.com>; Lance Andersen <lance.andersen at oracle.com>
Cc: nio-dev <nio-dev at openjdk.java.net>; core-libs-dev at openjdk.java.net
Subject: Re: RFR: 8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem
On 20/11/2019 08:15, Langer, Christoph wrote:
Hi Lance,
I’ve taken care of ModulesInCustomFileSystem then, too.
Updated webrev in place…
If the ModulesInCustomFileSystem test really needs to be changed then the private method that has been renamed to testZipFileSystem shoud have its parameter changed too. The parameter can be renamed to zipfile (or similar) as it's a file path to a zip file. While in the area, it should be changed to use the 1-arg newFileSystem method, no need to use the system class loader.
-Alan
More information about the core-libs-dev
mailing list