RFR: JDK-8234402: revert change that stopped providing JPackageToolProvider
Kevin Rushforth
kevin.rushforth at oracle.com
Wed Nov 20 14:39:06 UTC 2019
Looks good.
-- Kevin
On 11/20/2019 6:36 AM, Andy Herrick wrote:
> webrev revised in place at [2].
>
> /Andy
>
> On 11/19/2019 9:00 PM, Alexey Semenyuk wrote:
>> Andy,
>>
>> I guess
>> http://cr.openjdk.java.net/~herrick/8234402/webrev.02/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java.sdiff.html
>> can be reverted to its initial state now:
>> ---
>> public ToolProvider asToolProvider() {
>> return ToolProvider.findFirst(name).orElse(null);
>> }
>> ---
>>
>> - Alexey
>>
>> On 11/19/2019 7:00 PM, Andy Herrick wrote:
>>> Please review the jpackage fix for bug [1] at [2].
>>>
>>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>>> repository (jpackage).
>>>
>>> This change restores JPackageToolProvider and gets rid of the
>>> temporary factory class.
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8234402
>>>
>>> [2] http://cr.openjdk.java.net/~herrick/8234402/webrev.02/
>>>
>>> /Andy
>>>
>>
More information about the core-libs-dev
mailing list